stove/rougail
3
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Wiki Activity

Quick definition of an optional parameter variable #24

Merged
egarette merged 8 commits from optional_parameter_in_variable into develop 2024-09-04 17:30:38 +02:00
Conversation 1 Commits 8 Files changed 9 +12
gremond commented 2024-07-06 14:52:21 +02:00
Member
Copy link
No description provided.
gremond added 1 commit 2024-07-06 14:52:21 +02:00
gremond force-pushed optional_parameter_in_variable from cf5cf58d73 to 2c70cf4a84 2024-07-06 15:10:50 +02:00 Compare
gremond added 1 commit 2024-07-07 08:09:18 +02:00
gremond commented 2024-07-07 08:12:28 +02:00
Author
Member
Copy link

The tests concerning this feature are:

  • 90_optional_parameter_in_variable_default
  • 90_optional_parameter_in_variable_exists

and are passing.

We should consider the fact that in the src/rougail/tiramisureflector.py file all the calls of the populate_calculation() function should be framed by the same exception management procedure.

The tests concerning this feature are: - 90_optional_parameter_in_variable_default - 90_optional_parameter_in_variable_exists and are passing. We should consider the fact that in the `src/rougail/tiramisureflector.py` file all the calls of the `populate_calculation()` function should be framed by the same exception management procedure.
gnunux reviewed 2024-07-07 09:20:23 +02:00
src/rougail/error.py Outdated
@ -82,0 +85,4 @@
class VariableCalculationDependencyError(Exception):
"""When an 'optional=true' attribute is set, and
the target variable doesn't exists.
"""
gnunux commented 2024-07-07 09:20:23 +02:00
Contributor
Copy link

This comment should be more generic, maybe in future we will use it for a new attribute.

This comment should be more generic, maybe in future we will use it for a new attribute.
gremond marked this conversation as resolved
gnunux reviewed 2024-07-07 09:21:42 +02:00
src/rougail/object_model.py Outdated
@ -352,0 +351,4 @@
if self.optional:
msg = f'the dependent variable was not found "{self.optional}" for variable "{self.path}"'
raise VariableCalculationDependencyError(msg, 90, self.xmlfiles)
else:
gnunux commented 2024-07-07 09:21:42 +02:00
Contributor
Copy link

"else" is not useful here, we raises in the condition.

"else" is not useful here, we raises in the condition.
gremond marked this conversation as resolved
gnunux reviewed 2024-07-07 09:23:05 +02:00
tests/dictionaries/90_optional_parameter_in_variable_default/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:05 +02:00
Contributor
Copy link

"---" missing

"---" missing
gremond marked this conversation as resolved
gnunux reviewed 2024-07-07 09:23:29 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:29 +02:00
Contributor
Copy link

"---" missing

"---" missing
gremond marked this conversation as resolved
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:23:59 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux commented 2024-07-07 09:23:59 +02:00
Contributor
Copy link

"---" missing

"---" missing
gnunux reviewed 2024-07-07 09:24:10 +02:00
tests/dictionaries/90_optional_parameter_in_variable_exists/dictionaries/rougail/00-base.yml Outdated
@ -0,0 +1,13 @@
version: 1.1
my_variable:
gnunux commented 2024-07-07 09:24:10 +02:00
Contributor
Copy link

"---" missing

"---" missing
gremond added 1 commit 2024-07-09 10:38:15 +02:00
gremond changed title from WIP: Quick definition of an optional parameter variable to Quick definition of an optional parameter variable 2024-07-09 10:38:32 +02:00
gremond added 1 commit 2024-07-11 17:13:55 +02:00
gremond added 1 commit 2024-08-06 10:49:10 +02:00
gnunux force-pushed optional_parameter_in_variable from 92cac379e0 to 0c02807775 2024-08-06 10:51:46 +02:00 Compare
gremond added 1 commit 2024-08-07 18:01:26 +02:00
gnunux added 1 commit 2024-08-08 11:41:46 +02:00
gnunux force-pushed optional_parameter_in_variable from eeee06ad92 to ac56aea5f1 2024-09-04 17:30:06 +02:00 Compare
egarette merged commit f4503f3b10 into develop 2024-09-04 17:30:38 +02:00
egarette deleted branch optional_parameter_in_variable 2024-09-04 17:30:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: stove/rougail#24
No description provided.
Delete branch "optional_parameter_in_variable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?