stove/rougail
3
0
Fork 0
Code Issues 10 Pull requests 1 Projects Releases Wiki Activity

feat: add default inference behavior for basic types #13

Closed
gremond wants to merge 10 commits from basic_types_inference into develop
pull from: basic_types_inference
merge into: stove:develop
Conversation 0 Commits 10 Files changed 112 +8
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 463b57ea2d - Show all commits

8
src/rougail/annotator/value.py
View file

@ -62,6 +62,14 @@ class Annotator(Walk): # pylint: disable=R0903
variable: dict, variable: dict,
) -> None: ) -> None:
multi = self.objectspace.multis.get(variable.path, False) multi = self.objectspace.multis.get(variable.path, False)
types = {str: "string", int: "number", bool: "boolean", float: "float"}
# variable's type inference with a default value with a basic type
if multi is False and variable.type == "string" and type(variable.default) != str:
egarette commented 2024-04-09 12:09:51 +02:00
Outdated
Review
Copy link

This line is not correct to me.

Example:

my_var:
  type: string
  default: 3

is an invalid dictionary.

This line is not correct to me. Example: ``` my_var: type: string default: 3 ``` is an invalid dictionary.
if type(variable.default) in types:
variable.type = types[type(variable.default)]
egarette commented 2024-05-03 08:02:29 +02:00
Outdated
Review
Copy link

Not only 1.1, should be "else:"

Not only 1.1, should be "else:"
# a boolean must have value, the default value is "True" # a boolean must have value, the default value is "True"
if variable.type == "boolean" and multi is False and variable.default is None: if variable.type == "boolean" and multi is False and variable.default is None:
variable.default = True variable.default = True