stove/tiramisu
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: better port validation with the value ''

Browse source
This commit is contained in:
egarette@silique.fr 2025-05-23 17:56:58 +02:00
parent 379630fc38
commit ebc9779173
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/test_config_api.py
View file

@ -352,6 +352,8 @@ def test_invalid_option():
PortOption('a', '', allow_zero=False, allow_wellknown=False, allow_registred=False, allow_private=False) PortOption('a', '', allow_zero=False, allow_wellknown=False, allow_registred=False, allow_private=False)
with raises(ValueError): with raises(ValueError):
PortOption('a', '', 'tcp:80') PortOption('a', '', 'tcp:80')
with raises(ValueError):
PortOption('a', '', '')
NetworkOption('a', '') NetworkOption('a', '')
with raises(ValueError): with raises(ValueError):
NetworkOption('a', '', 'string') NetworkOption('a', '', 'string')

5
tiramisu/option/portoption.py
View file

@ -20,8 +20,6 @@
# ____________________________________________________________ # ____________________________________________________________
"""PortOption """PortOption
""" """
import re
from ..i18n import _ from ..i18n import _
from .stroption import StrOption from .stroption import StrOption
@ -38,7 +36,6 @@ class PortOption(StrOption):
""" """
__slots__ = tuple() __slots__ = tuple()
port_re = re.compile(r"^[0-9]*$")
_type = "port" _type = "port"
def __init__( def __init__(
@ -104,7 +101,7 @@ class PortOption(StrOption):
value = [value] value = [value]
for val in value: for val in value:
if not self.port_re.search(val): if not val.isdecimal():
raise ValueError() raise ValueError()
def second_level_validation(self, value: str, warnings_only: bool) -> None: def second_level_validation(self, value: str, warnings_only: bool) -> None: