From db82dd6d41fbc9ea5a9e1b48aae8a2c5951a7533 Mon Sep 17 00:00:00 2001
From: Emmanuel Garette <egarette@silique.fr>
Date: Wed, 9 Apr 2025 08:27:38 +0200
Subject: [PATCH] fix: better error message

---
 locale/fr/LC_MESSAGES/tiramisu.po          |  48 +++++++++++----------
 locale/tiramisu.pot                        |  28 ++++++------
 tests/test_config.py                       |   4 +-
 tiramisu/locale/fr/LC_MESSAGES/tiramisu.mo | Bin 27045 -> 26783 bytes
 tiramisu/option/dynoptiondescription.py    |   2 +-
 tiramisu/option/optiondescription.py       |  22 ++++++----
 6 files changed, 53 insertions(+), 51 deletions(-)

diff --git a/locale/fr/LC_MESSAGES/tiramisu.po b/locale/fr/LC_MESSAGES/tiramisu.po
index f5ac667..dfe63cd 100644
--- a/locale/fr/LC_MESSAGES/tiramisu.po
+++ b/locale/fr/LC_MESSAGES/tiramisu.po
@@ -2,7 +2,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Tiramisu\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-03-19 09:51+0100\n"
+"POT-Creation-Date: 2025-04-09 08:14+0200\n"
 "PO-Revision-Date: \n"
 "Last-Translator: Emmanuel Garette <egarette@cadoles.com>\n"
 "Language-Team: Tiramisu's team <egarette@cadoles.com>\n"
@@ -90,7 +90,7 @@ msgstr ""
 msgid "cannot find \"{0}\" in option \"{1}\" at index \"{2}\""
 msgstr "ne peut trouver \"{0}\" dans l'option \"{1}\" à l'index \"{2}\""
 
-#: tiramisu/api.py:679
+#: tiramisu/api.py:679 tiramisu/option/optiondescription.py:283
 msgid "cannot find \"{0}\""
 msgstr "ne peut trouver \"{0}\""
 
@@ -619,7 +619,7 @@ msgstr "ne doit pas être une IP"
 msgid "some characters are uppercase"
 msgstr "des caractères sont en majuscule"
 
-#: tiramisu/option/dynoptiondescription.py:131
+#: tiramisu/option/dynoptiondescription.py:130
 msgid "DynOptionDescription identifiers for option {0}, is not a list ({1})"
 msgstr ""
 "les identifiants de la DynOptionDescription pour l'option {0}, n'est pas une "
@@ -806,41 +806,34 @@ msgstr "lequel \"{}\" doit être une liste de liste"
 msgid "duplicate option: {0}"
 msgstr "option dupliquée : {0}"
 
-#: tiramisu/option/optiondescription.py:244
-msgid ""
-"unknown option \"{0}\" in root optiondescription (it's a dynamic option)"
-msgstr ""
-"option \"{0}\" inconnue dans l'optiondescription racine (c'est une option "
-"dynamique)"
+#: tiramisu/option/optiondescription.py:249
+msgid "cannot access to \"{0}\" it's a dynamic option"
+msgstr "ne peut accéder à \"{0}\" c'est une option dynamique"
 
-#: tiramisu/option/optiondescription.py:279
-msgid "unknown option \"{0}\" in root optiondescription"
-msgstr "option \"{0}\" inconnue dans l'optiondescription racine"
+#: tiramisu/option/optiondescription.py:286
+msgid "cannot find \"{0}\" in \"{1}\""
+msgstr "ne peut pas trouver \"{0}\" dans \"{1}\""
 
-#: tiramisu/option/optiondescription.py:282
-msgid "unknown option \"{0}\" in optiondescription {1}"
-msgstr "option \"{0}\" inconnue dans l'optiondescription {1}"
-
-#: tiramisu/option/optiondescription.py:338
+#: tiramisu/option/optiondescription.py:342
 msgid "children in optiondescription \"{}\" must be a list"
 msgstr "les enfants d'une optiondescription \"{}\" doivent être une liste"
 
-#: tiramisu/option/optiondescription.py:366
+#: tiramisu/option/optiondescription.py:370
 msgid "duplicate option name: \"{0}\""
 msgstr "nom de l'option dupliqué : \"{0}\""
 
-#: tiramisu/option/optiondescription.py:372
+#: tiramisu/option/optiondescription.py:376
 msgid ""
 "the option's name \"{0}\" start as the dynoptiondescription's name \"{1}\""
 msgstr ""
 "le nom de l'option \"{0}\" commence comme le nom du dynoptiondescription "
 "\"{1}\""
 
-#: tiramisu/option/optiondescription.py:415
+#: tiramisu/option/optiondescription.py:419
 msgid "cannot change group_type if already set (old {0}, new {1})"
 msgstr "ne peut changer group_type si déjà spécifié (ancien {0}, nouveau {1})"
 
-#: tiramisu/option/optiondescription.py:420
+#: tiramisu/option/optiondescription.py:424
 msgid "group_type: {0} not allowed"
 msgstr "group_type : {0} non autorisé"
 
@@ -1028,8 +1021,17 @@ msgstr ""
 msgid "information's item not found \"{}\""
 msgstr "l'information de l'objet ne sont pas trouvé \"{}\""
 
-#~ msgid "cannot find {0} \"{1}\""
-#~ msgstr "ne peut pas trouver {0} \"{1}\""
+#~ msgid ""
+#~ "unknown option \"{0}\" in root optiondescription (it's a dynamic option)"
+#~ msgstr ""
+#~ "option \"{0}\" inconnue dans l'optiondescription racine (c'est une option "
+#~ "dynamique)"
+
+#~ msgid "unknown option \"{0}\" in root optiondescription"
+#~ msgstr "option \"{0}\" inconnue dans l'optiondescription racine"
+
+#~ msgid "unknown option \"{0}\" in optiondescription {1}"
+#~ msgstr "option \"{0}\" inconnue dans l'optiondescription {1}"
 
 #~ msgid ""
 #~ "IP \"{ip[\"value\"]}\" ({ip[\"name\"]}) with this netmask is in fact a "
diff --git a/locale/tiramisu.pot b/locale/tiramisu.pot
index 193f8f8..1322953 100644
--- a/locale/tiramisu.pot
+++ b/locale/tiramisu.pot
@@ -5,7 +5,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
-"POT-Creation-Date: 2025-03-19 09:54+0100\n"
+"POT-Creation-Date: 2025-04-09 08:16+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -79,7 +79,7 @@ msgstr ""
 msgid "cannot find \"{0}\" in option \"{1}\" at index \"{2}\""
 msgstr ""
 
-#: tiramisu/api.py:679
+#: tiramisu/api.py:679 tiramisu/option/optiondescription.py:283
 msgid "cannot find \"{0}\""
 msgstr ""
 
@@ -532,7 +532,7 @@ msgstr ""
 msgid "some characters are uppercase"
 msgstr ""
 
-#: tiramisu/option/dynoptiondescription.py:131
+#: tiramisu/option/dynoptiondescription.py:130
 msgid "DynOptionDescription identifiers for option {0}, is not a list ({1})"
 msgstr ""
 
@@ -700,35 +700,31 @@ msgstr ""
 msgid "duplicate option: {0}"
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:244
-msgid "unknown option \"{0}\" in root optiondescription (it's a dynamic option)"
+#: tiramisu/option/optiondescription.py:249
+msgid "cannot access to \"{0}\" it's a dynamic option"
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:279
-msgid "unknown option \"{0}\" in root optiondescription"
+#: tiramisu/option/optiondescription.py:286
+msgid "cannot find \"{0}\" in \"{1}\""
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:282
-msgid "unknown option \"{0}\" in optiondescription {1}"
-msgstr ""
-
-#: tiramisu/option/optiondescription.py:338
+#: tiramisu/option/optiondescription.py:342
 msgid "children in optiondescription \"{}\" must be a list"
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:366
+#: tiramisu/option/optiondescription.py:370
 msgid "duplicate option name: \"{0}\""
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:372
+#: tiramisu/option/optiondescription.py:376
 msgid "the option's name \"{0}\" start as the dynoptiondescription's name \"{1}\""
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:415
+#: tiramisu/option/optiondescription.py:419
 msgid "cannot change group_type if already set (old {0}, new {1})"
 msgstr ""
 
-#: tiramisu/option/optiondescription.py:420
+#: tiramisu/option/optiondescription.py:424
 msgid "group_type: {0} not allowed"
 msgstr ""
 
diff --git a/tests/test_config.py b/tests/test_config.py
index 7efb323..56f1ee5 100644
--- a/tests/test_config.py
+++ b/tests/test_config.py
@@ -380,12 +380,12 @@ def test_prefix_error():
     try:
         cfg.option('test1').value.set('yes')
     except Exception as err:
-        assert str(err) == _('"{0}" is an invalid {1} for "{2}"').format('yes', _('integer'), 'test1')
+        assert str(err) == _('"{0}" is an invalid {1} for "{2}", which is not an integer').format('yes', _('integer'), 'test1')
     try:
         cfg.option('test1').value.set('yes')
     except Exception as err:
         err.prefix = ''
-        assert str(err) == _('invalid value')
+        assert str(err) == _('which is not an integer')
 #    assert not list_sessions()
 
 
diff --git a/tiramisu/locale/fr/LC_MESSAGES/tiramisu.mo b/tiramisu/locale/fr/LC_MESSAGES/tiramisu.mo
index a1b4837ec355f508aff2a1356fbad9dca5d2002a..9c16744b0f98aeef12d7290196148e8b6df883e6 100644
GIT binary patch
delta 3682
zcmZA3c~Dhl9LDjNMGVOW+*m{|mk?Y~+>lU$1b0nLb0IfCR4Nfd2~xaZxo_E3TeQX0
z(n?dWyX9JHCAj78*f`@q<ye-L)#%js;hftzz2n2@eGm7X^Pczpor@dJ`Mh_=$8|l#
zf2E;aBQ41N0Apf(7}wWPV~RqI@yBB9fu-0AJs6EwFcI%#J4|S7Ob5)y1YC&8xCeFp
zUoa3GG%=>BF)kBIM;B_31279SaSf*74NS#oKCR>9P#0K_g}4P%FtVBTxsmu7<5d`r
z`%x3VfHC+0{V=*Y=Wu@$OQ$6VGEgVxVkex3PvSm&0`FrZ>>g@NM;wTH@>!_kpP^RZ
z5bFHf*clyR*70GO#JCEha1Tc7hL`Bf!oN{ZQqHu4aR=%Nj(L{*?Duy?(rv*78e$4+
zb^D_~mSG#LK;3&Iay4@mTjTGj^P{>M(-u=vb0|RV)&kTf>_yhoT*c=23$p$uFj+fA
zr)9D+5!ekix1kt|g;?QZ%nH<mLQ;$wgw0VC$VctsGVF@g_&EA?x1Ko_yD%<8eQq;4
z@fHSQgC6XZo*<ke)QppHB2LDUcnWpHc+T#Nr8p1|Vtss+Eu4wrn2m3se*Y_Kf@x{?
zilA0#0mkD_^u_BgI;x)=s9md*ZrKJ|T{9T_;9PtfYcLd}sUhxRQjkNY9JRFjP)~do
zwIX$UT2G#e?HSL&5%@7CpvyPITIxhx$ARJ45C2B(S!Sj+p={I>xsX*hn=l%0Vlxcr
zMGa#lY67EBPrMY_J+sgDE{<i~uD3BIdQ%tC(FOlOEp-Zy%e~EfRMDM8>c#wn>DY~Z
z&>okeKDXWW59Fat3bT*G3e@%9LGAS|9Dw&w6VK?c6?0KUbZSq)x;g>%CT>8s*<3{a
znWmgwgyS&)&tOZugl+L2>T@v^Kr1Z7VYm`!<BzBZnZm4Uua7C*-&~}Viy=>0Uk%f-
z9pl{?fj4c<VC(g3fw3G<LLSD9#tHZ#R$)+<F?=7ICD;(xVjONmCtgOKe;-|~={Sd2
zTQCsg8PCHs+=|qZxq~XcPW%YRIhcU&qrQu3P*3bT)S6&x)O9nkF-}1hZ58VJZ=)t~
zbSUdzM&}0(lw&UIRe{$~E0g_<RfJbiOMM4pu;Fma&Pe^45vU?tgQM^~YD+s%>bmh@
zOvK6f3ciI}@yL<fMb%n4(wg~BR56}H3f0u(YAUuY)JiPGY&?mo_BaOG^E~v$Em#M)
zp+3JG^_u>LT9M>utp~|P)l8L(j`n&pCgBy-(g%;WZZHHjUV@FV8uj_>7>q$<tP4ll
z_OUI-7W{rSYHRk`evi?N19%77RpW}Mvx3gc*c}^=vzB%M@>w$#i?JHhF>So{4OfW{
z#?`2z`UxEvoMY8UCuEh)AXJfVz)JiXc~eah>(A@!GJEL+ao_=J$piDOCmf7gk(t;H
zJ+`+nopB5$&nadCYNE$66=U;xlQ0jPU@7V?ScI{-+8!UqE~>IKbhMNK6Rp1ip{PCY
zi!E_BYRT84E>MG=@HbR7$4#<UE(^8Ci&4jSp^EQ&+dnaiaqwj8weE;c?r#RsX^%zd
zgPG(x(wL}eGN;Kmq=1|tbICUHDN%ceJX+hcek9xd^Y{fRA_1g|=wUu0YPx@Ip>)Jj
zGKYLlw3KH^I`I%cvX@*SZxb!)0iqUR@!!w+^r&O=AsJ5`WEOe2U1U&U-`{Lxpf8k{
z32&ZROwx#&_Hqw-i>xLp)~=*8`GEM7;pG2KHPe&SCq3+6YWq}_YI^e8|Eck<S^J0L
zGO7-ilJ`hC;kB*(YTbfkh}sUaj;Oet#M?fh!=C_Ck8C1el2PO(qB=?;Wh9U+BsC;S
zv$#Y~kqq)R`Iby4-nP=)dC1r4w;{VoTl@HHw&QH8u@8BYyie*9Z;PUHg}Ac3NAL*Q
zZjV31V`P{;9*xm<|6%kd>?8BY$K+iSPabZ&85}1Y$ZT?zs5SHMzXo~(rjn;gUy?`;
z6K~^BggI&t9>YgS9Wu~9b`8Vres9|_EGCV}B(i`^A!=jE3{`<Io&97jQCmXd$W{$#
z`Q#w!t^w_=h4~6Qkk%yBKIWx_&YL8c#MlRe@Ky2#dC@-BpZl9-_Mj=c$s&8~<s6+Z
z_TVY(XZM@qcchT)B(IPhvWhGxYseF%0ePNGB!@^Z@&d^tn!Kqbo5@V_44F*Ulapi!
znMPW9c7{v{h;YtGtZ+ICrp1*wavT%N3v;Fv<T<7mO)HpM=q?O%x(`Hzxl6;sG0>AA
zw%o`4AUw|F8{v%boJcwn<giZ9i_0&W=9pfXZ=Y#jsCat5`;(pt?wVd9o*g|Sef^4Z
YO5CS2o49XhcJTa~dDr1tJJH|oUtjRP!T<mO

delta 3931
zcmb8wd2p2F0mt!YlK>)#N`Pc@?=DvY2Dt*^k^}-VfEXI?L%}4(tz;Jxh*F5lWj*l<
zpr97<qEgV7RRK{%6i`r+OKcT7j-oTlh%?McM_TRox6hNA*gtgo%>43so;UCDywCCO
z#-pC+j(Z|!k`vY%%4w2G651Hk&tuHFBpo$oXEMid7Y@Ze*bOhC9|IkX>5V0LH7>$y
z@M+A)V_1l$qrLwiY)f-8b}}YnW>e9P8gMK=h9&qV4#zys8iqmC@y)0koWl_QfP=9*
z#h&*RcA<R+(=k5Pb~qb5(;kKK7{n}|Z)&MzbKpMIg<G&M9>HRa^BQw4mf%&m68qp9
z)SDl0$1kF;yDW_n#385=3F82K0(0;<>V+@h9lWIJL^t&YYp^{YiEi@jPKapqGP$r9
zj=|Bm7_)FMUWsQ==Y59>m^sjx9_UB)WgPMt6Tv)OkGlSC?1`VF`jk{?XDuJqw^@aZ
z3<GN-97x5rsJ?DPFYdz({1i3H7qKfQ4>G3F!<3^s^eQiQJ?=(zpzRPlOZ~8b_5$Qo
zvl%(Xe2)Dwb0{;TX`jHN3*dv;4!5J;U=M1YeTH)}k&~xlJ?eq)<8_$M)Q!VROv1n7
zQrv^namaA{|8=Miet|id6e+Spl#jU_n1*q<0=16rL@k#WoF5{yU@l-O_F(P&4(rg1
z`;ljwGgyRKBkaiDh#H9oq|at6YRV(uP?<s{ZKR#!1*jq3h|l1DEW=<)Y$us0>J8pQ
z4dn&&W3N%hq+mHRx~2v-#LuACz$eJ;nFJP?9ELY)XEso&=fFwS4a;~f4ecuA+2$B(
zk)<%stRqu~MYtR_r~6Rn{o7eYZ+R!P3N^$BQTO{AHMIp}>=&RI{o0wUsc7-Ngs}^-
zjV?g#!1Jgf^N(eR;7vFmw_t0`VB)hefIYDobzUuY!<{%0|A{NGKfTe5?7%)e-<+qS
zH}{V>=4PCUOrLoZuSU-eb{F(=j=?mJ&&95|40$>8JXYcNxEv>y8^d?eoWd*dTkMXP
zFo2yWF#fv1XexO)57m)%n2SeoIR1$0&|p@Y7TZ$(q~j6H$8S*IB5#F#<8i1C)}!vb
z8av<))FM5My8o9IjK4aN#Q5Bf{ctgE#YXHlNh`#dXR#A@nQVu8Fm|Rr&Dn^oL$e9B
zxW2+^n8V7}lrBa+cs=&U?YI)Zn8MvP<TX?6YCVMN`Om14NaHRnTr&{|;Re)5oWSXr
z!XK^n1*kdShH>~WY=xIl=X++@Z8;J(A}dg9W^06s7R_PQTwlZi*kz_2`WZNc_T#R7
z3a_G_I?JA)i|uJoLfyE=`LJ_0W^(*2YB9#K=VTuGF;Y&2={0q@2H!zFaN13Fh}R<5
znq9a6Q)k=lcMr0l%^~z*>KwbM3Q_GDn2t-4(Ke4_8J@>wIEZ0q$41O+RJ4ENEA9R)
zMGbicYDCtfM&tkv#Q!)8Sn5TzYmr-+7f~H;Uv0N*7?Wvl!;ZKYwF^#SUp$KiT3z0`
zc2$qZuKZ&Y>coTCA5Wo%II+h57G$H=!g$QayHOq8jJo~=>H$BZR(bv{c0?zmrsxsW
z@z>GI^UYaR@F&c{)S%t(12I6m0`;wKKo4#vDo4nJL=RQD%wj&qy{>+nvzb3qIZar<
zv6qV!Q@N9TM%EGy<y}NYZ<Rv&sX-Y|x{;OS8p2e@3L_uewp}oe=$kN+s5FwoSdA|y
zHW7`UE0NfbOdhRv<Pdp^G?&q?q6MkKcg8#ttML<yZOO~7E#|rUNBEelAHWW-z90WU
zSmUwn9s9aGN@FSE8)Kd%ACjX)MO*E1l1zS2ZYNKZ9wfFKa63`Cm#iQ=)SxURZ^UZ$
z&x<YUs$NHSYW@>QD^f!4Bh95Rm2u?nq>i*9Di4v@$VqYqDJN5jO2}dk<11vYYp=mx
zu6_)YTs`sx6}~yYD9_UR)E$}PT;AdgZATTYe(jXMsX<vq9wy_}aAgVpg={466MpN=
z4P-2#L}EX&d#G(7vx&+sGJ@<=gEEpFkJaq=do}ef<W}M%DsPcA^0pe3_2fM=fxJ$J
zkusukkVHvP`@e?DDbiftp;Av;lN@)j6E?W|yUypa$kp$_ZDb7j6Uid?ljh=Wt~ht&
zI@LA*{~(``fux$WEJJB*B8%L?mz-f-MqVZHL?vJ`6`1boxj2j5LfVs_WIj1T-XxKZ
z{P}=X5*2kwC4+1w50LIeWilxxqev|&AerPIaxIxo9w(hiB55wqQTa2uo6KxJh%e}K
z;g8lPSGA7*<UQ?a@@6DP<1zvniQ)MRgW-@bu%vfmpy}tVl*p1kjb>5k)=>Dikgw%G
zeZi2gE*xIy4pvpySJnk%7yqB9`*MQ|yVv{X_^K9%=F|o&-3{~XZKD1G``bk`MwG@y
z?<(o&FaMt|RE9&LMb*BlIiY&ryzcg&ExO`U?|=1@rf_Lm)^DBRjq~L;ohwfF<V81B
Hw~GHSNe2R>

diff --git a/tiramisu/option/dynoptiondescription.py b/tiramisu/option/dynoptiondescription.py
index 47f8dba..d840db9 100644
--- a/tiramisu/option/dynoptiondescription.py
+++ b/tiramisu/option/dynoptiondescription.py
@@ -124,7 +124,6 @@ class DynOptionDescription(OptionDescription):
         )[0]
         if values is None:
             values = []
-        values_ = []
         if __debug__:
             if not isinstance(values, list):
                 raise ValueError(
@@ -134,6 +133,7 @@ class DynOptionDescription(OptionDescription):
                         self.impl_get_display_name(subconfig, with_quote=True), values
                     )
                 )
+        values_ = []
         for val in values:
             cval = self.convert_identifier_to_path(val)
             if not isinstance(cval, str) or re.match(NAME_REGEXP, cval) is None:
diff --git a/tiramisu/option/optiondescription.py b/tiramisu/option/optiondescription.py
index b1ba72e..c086050 100644
--- a/tiramisu/option/optiondescription.py
+++ b/tiramisu/option/optiondescription.py
@@ -232,18 +232,21 @@ class OptionDescriptionWalk(CacheOptionDescription):
 
     def get_child_not_dynamic(
         self,
-        name,
-        allow_dynoption,
+        name: str,
+        allow_dynoption: bool,
+        parent: "SubConfig",
     ):
         if name in self._children[0]:  # pylint: disable=no-member
             option = self._children[1][
                 self._children[0].index(name)
             ]  # pylint: disable=no-member
             if option.impl_is_dynoptiondescription() and not allow_dynoption:
+                if parent.path:
+                    path = parent.path + '.' + name
+                else:
+                    path = name
                 raise AttributeError(
-                    _(
-                        'unknown option "{0}" in root optiondescription (it\'s a dynamic option)'
-                    ).format(name)
+                    _('cannot access to "{0}" it\'s a dynamic option').format(path)
                 )
             return option
 
@@ -261,6 +264,7 @@ class OptionDescriptionWalk(CacheOptionDescription):
         option = self.get_child_not_dynamic(
             name,
             allow_dynoption,
+            parent,
         )
         if option:
             return option
@@ -274,13 +278,13 @@ class OptionDescriptionWalk(CacheOptionDescription):
                 if not with_identifier:
                     return child
                 return identifier, child
-        if self.impl_get_group_type() == groups.root:  # pylint: disable=no-member
+        if parent.path is None:
             raise AttributeError(
-                _('unknown option "{0}" in root optiondescription').format(name)
+                _('cannot find "{0}"').format(name)
             )
         raise AttributeError(
-            _('unknown option "{0}" in optiondescription {1}').format(
-                name, self.impl_get_display_name(parent, with_quote=True)
+            _('cannot find "{0}" in "{1}"').format(
+                name, parent.path
             )
         )